pjfawcett commented on pull request #29: URL: https://github.com/apache/qpid-cpp/pull/29#issuecomment-1044902513
I haven't been able to determine the specific reason why the tests were failing. I am having difficulty running the HA tests locally (Perhaps my machine is a little underpowered for running a failover cluster). However, if I removed the code I had put in to call `abort_pending()` then the tests passed. Perhaps it those calls were interfering with the synchronisation between members of the HA cluster. I have left in the check for NULL when processing the pending acknowledgements and so this PR still achieves the original aim of preventing the SegFaults I had encountered. I hope it can now be considered for merging. I will squash the commits in preparation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
