[
https://issues.apache.org/jira/browse/DISPATCH-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506270#comment-17506270
]
ASF GitHub Bot commented on DISPATCH-2336:
------------------------------------------
ganeshmurthy commented on a change in pull request #1536:
URL: https://github.com/apache/qpid-dispatch/pull/1536#discussion_r826045500
##########
File path: dockerfiles/Dockerfile-ubuntu
##########
@@ -16,14 +16,17 @@
# specific language governing permissions and limitations
# under the License.
#
+
# Copy this docker file to your local folder. Build the docker file like this
- sudo docker build -t <username>/dispatch --file=Dockerfile-ubuntu . (don't
miss the dot at the end)
# To run it - sudo docker run -i -t <username>/dispatch (this will launch the
dispatch router)
-# Gets the trusty Ubuntu from dockerhub
-FROM ubuntu:latest
+# Gets the Ubuntu from dockerhub
+FROM docker.io/library/ubuntu:focal
Review comment:
Yes, let's leave the FROM line as it was before except just change
latest to focal. Ideally, if
https://issues.apache.org/jira/browse/DISPATCH-2337 was fixed, then there would
be no need to change this line but as you say for now focal is ok. Leave the
docker.io/library out of it.
If you are also fixing the fedora dockerfile in this PR, then please change
the JIRA description to say fedora as well. Since the centos dockerfile is also
being fixed in this PR and dockerfiles/Dockerfile-fedora-only-python3 is being
deleted, maybe the JIRA should be more generic like "Fix the dockerfiles in the
dockerfiles folder" or something.
Also commit message is missing a colon after the JIRA number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dockerfile-ubuntu not building
> ------------------------------
>
> Key: DISPATCH-2336
> URL: https://issues.apache.org/jira/browse/DISPATCH-2336
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.18.0
> Reporter: Birgen Geelen
> Assignee: Jiri Daněk
> Priority: Minor
> Fix For: 1.19.0
>
>
> 2 issues while building the docker image using command:
> sudo docker build -t docker-image-name --file=Dockerfile-ubuntu
> * 1st Error raised is:
> {code:java}
> STEP 5/13: RUN pip3 install quart selectors grpcio protobuf h2
> /bin/sh: 1: pip3: not found
> Error: error building at STEP "RUN pip3 install quart selectors grpcio
> protobuf h2": error while running runtime: exit status 127 {code}
> Can be fixed by adding python3-pip to the list of packages to be installed
> Dockerfile-ubuntu.
>
>
> * 2nd error: incorrect change directory statement
> Diff for fix:
> diff Dockerfile-ubuntu Dockerfile-ubuntu.old
> 29c29
> < apt-get install -y curl gcc g++ automake libwebsockets-dev libtool
> zlib1g-dev cmake libsasl2-dev libssl-dev libnghttp2-dev python3-dev
> *_+python3-pip+_* libuv1-dev sasl2-bin swig maven git && \
> —
> > apt-get install -y curl gcc g++ automake libwebsockets-dev libtool
> > zlib1g-dev cmake libsasl2-dev libssl-dev libnghttp2-dev python3-dev
> > libuv1-dev sasl2-bin swig maven git && \
> 34c34
> < RUN git clone [https://gitbox.apache.org/repos/asf/qpid-dispatch.git] && cd
> *_+qpid-dispatch+_* && git submodule add
> [https://gitbox.apache.org/repos/asf/qpid-proton.git] && git submodule update
> --init
> —
> > RUN git clone [https://gitbox.apache.org/repos/asf/qpid-dispatch.git] && cd
> > *{color:#FF0000}/qpid-dispatch{color}* && git submodule add
> > [https://gitbox.apache.org/repos/asf/qpid-proton.git] && git submodule
> > update --init
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
