[
https://issues.apache.org/jira/browse/DISPATCH-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532705#comment-17532705
]
ASF GitHub Bot commented on DISPATCH-1689:
------------------------------------------
codecov-commenter commented on PR #1564:
URL: https://github.com/apache/qpid-dispatch/pull/1564#issuecomment-1119382822
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1564?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1564](https://codecov.io/gh/apache/qpid-dispatch/pull/1564?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(bdcdf04) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/b533ed930ff5fe7d55fec562b4480048a17a0e5d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(b533ed9) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1564 +/- ##
==========================================
- Coverage 85.89% 85.78% -0.11%
==========================================
Files 110 110
Lines 24701 24700 -1
==========================================
- Hits 21217 21190 -27
- Misses 3484 3510 +26
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j)
| `86.29% <ø> (ø)` | |
|
[...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j)
| `78.69% <0.00%> (-4.15%)` | :arrow_down: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `85.01% <0.00%> (-1.42%)` | :arrow_down: |
|
[src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=)
| `84.15% <0.00%> (-1.00%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `92.97% <0.00%> (-0.56%)` | :arrow_down: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.06% <0.00%> (-0.40%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `92.97% <0.00%> (-0.20%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `86.88% <0.00%> (-0.20%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==)
| `87.84% <0.00%> (-0.01%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1564?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1564?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[b533ed9...bdcdf04](https://codecov.io/gh/apache/qpid-dispatch/pull/1564?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> [test] test framework can't handle qdrouter that is torn down too soon
> ----------------------------------------------------------------------
>
> Key: DISPATCH-1689
> URL: https://issues.apache.org/jira/browse/DISPATCH-1689
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.12.0
> Reporter: Charles E. Rolke
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: 1.20.0
>
>
> Demonstration steps:
> # simple router is created with cls.tester.qdrouterd(..., wait=False)
> # skip cls.router.wait_ready()
> # run a test that executes quickly and creates no connection to the router
> Then default teardown will show something like:
> {noformat}
> 24: ERROR
> 24:
> 24: ======================================================================
> 24: ERROR: tearDownClass (system_tests_policy.PolicyWarnings)
> 24: ----------------------------------------------------------------------
> 24: Traceback (most recent call last):
> 24: File "/home/chug/git/qpid-dispatch/tests/system_test.py", line 723, in
> tearDownClass
> 24: cls.tester.teardown()
> 24: File "/home/chug/git/qpid-dispatch/tests/system_test.py", line 669, in
> teardown
> 24: raise RuntimeError("Errors during teardown: \n\n%s" %
> "\n\n".join([str(e) for e in errors]))
> 24: RuntimeError: Errors during teardown:
> 24:
> 24: Process 65135 error: exit code -15, expected 0
> 24: qdrouterd -c PolicyWarnings.conf -I /home/chug/git/qpid-dispatch/python
> 24:
> /home/chug/git/qpid-dispatch/build/tests/system_test.dir/system_tests_policy/PolicyWarnings/setUpClass/PolicyWarnings-1.cmd
> 24: >>>>
> 24: <<<<
> {noformat}
> The router did not crash and the test did nothing to cause a teardown issue.
> Conversely the test can do nothing to fix the issue outside of a sleep.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
