[ 
https://issues.apache.org/jira/browse/QPID-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532791#comment-17532791
 ] 

ASF GitHub Bot commented on QPID-8581:
--------------------------------------

dakirily commented on code in PR #121:
URL: https://github.com/apache/qpid-broker-j/pull/121#discussion_r866736034


##########
broker-core/src/main/java/org/apache/qpid/server/model/port/HttpPort.java:
##########
@@ -72,6 +72,21 @@
     @ManagedContextDefault(name = TLS_SESSION_CACHE_SIZE, description = "TLS 
session cache size for HTTP ports.")
     int DEFAULT_TLS_SESSION_CACHE_SIZE = 1000;
 
+    String QUERY_ENGINE_CACHE_SIZE = "qpid.port.http.query.engine.cacheSize";
+    @SuppressWarnings("unused")
+    @ManagedContextDefault(name = QUERY_ENGINE_CACHE_SIZE, description = 
"Broker query engine cache size.")
+    int DEFAULT_QUERY_ENGINE_CACHE_SIZE = 1000;
+
+    String QUERY_ENGINE_MAX_QUERY_DEPTH = 
"qpid.port.http.query.engine.maxQueryDepth";
+    @SuppressWarnings("unused")
+    @ManagedContextDefault(name = QUERY_ENGINE_MAX_QUERY_DEPTH, description = 
"Broker query engine max query depth.")
+    int DEFAULT_QUERY_ENGINE_MAX_QUERY_DEPTH = 4096;
+
+    String QUERY_ENGINE_ZONE_ID = "qpid.port.http.query.engine.zoneId";
+    @SuppressWarnings("unused")
+    @ManagedContextDefault(name = QUERY_ENGINE_ZONE_ID, description = "Broker 
query engine zone id.")

Review Comment:
   Changed variable name as well as the description to include the word "time"





> [Broker-J] Broker-J Query REST API improvements
> -----------------------------------------------
>
>                 Key: QPID-8581
>                 URL: https://issues.apache.org/jira/browse/QPID-8581
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>    Affects Versions: qpid-java-broker-8.0.6
>            Reporter: Daniil Kirilyuk
>            Priority: Minor
>
> Existing broker REST API (including broker query API) doesn’t support such 
> functions as aggregation, grouping and using nested logical operators, which 
> could be useful for gathering broker statistics and reporting.
> We suggest to add a new POST method for the endpoint /api/latest/querybroker 
> and supply search criteria using JSON body. (Existing GET method 
> implementation should stay without changes for keeping backwards 
> compatibility and because of difficulties of parsing complicated search 
> conditions from URI parameters when using GET request method).
> The new functionality should add
>  * logical OR operator (absent in current API)
>  * aggregation operators AVG, CNT, MAX, MIN, SUM
>  * grouping aggregation
>  * new numeric / datetime / string functions



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to