[
https://issues.apache.org/jira/browse/QPID-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614177#comment-17614177
]
ASF GitHub Bot commented on QPID-8604:
--------------------------------------
dakirily opened a new pull request, #145:
URL: https://github.com/apache/qpid-broker-j/pull/145
This PR addresses issue
[QPID-8604](https://issues.apache.org/jira/browse/QPID-8604) marking non-static
inner classes having a reference to its outer class, and access to the outer
class' fields and methods as static
> [Broker-J] Broker code cleanup: immutable fields, static inner classes, long
> literals
> -------------------------------------------------------------------------------------
>
> Key: QPID-8604
> URL: https://issues.apache.org/jira/browse/QPID-8604
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-8.0.6
> Reporter: Daniil Kirilyuk
> Priority: Minor
>
> Following issues are covered with this JIRA:
> 1. Private fields whose values never change once they are initialized either
> in the declaration of the field or by a constructor should be marked as
> final. This aids in converting existing classes to immutable classes.
> 2. A non-static inner class has a reference to its outer class, and access to
> the outer class' fields and methods. That class reference makes the inner
> class larger and could cause the outer class instance to live in memory
> longer than necessary.
> 3. There are many places in the broker code where long literals end with
> lowercase 'l' character mimicking the '1'. They should be replaced with
> uppercase 'L'.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
