[jira] [Commented] (DISPATCH-2355) Implement the `format` attribute for `qd_log_impl` and other such functions to hopefully have compile-time check for format strings

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/DISPATCH-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708369#comment-17708369
 ] 

ASF GitHub Bot commented on DISPATCH-2355:
------------------------------------------

jiridanek commented on PR #1630:
URL: https://github.com/apache/qpid-dispatch/pull/1630#issuecomment-1495764877

   @ganeshmurthy 100% tests pass again!




> Implement the `format` attribute for `qd_log_impl` and other such functions 
> to hopefully have compile-time check for format strings
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-2355
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2355
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 1.19.0
>            Reporter: Jiri Daněk
>            Priority: Major
>             Fix For: 1.20.0
>
>         Attachments: image-2023-04-02-21-25-09-798.png
>
>
> https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes
> {code}
> void qd_log_impl(qd_log_source_t *source, qd_log_level_t level, const char 
> *file, int line, const char *fmt, ...) __attribute__(( format(printf,5,6) ));
> {code}
>  !image-2023-04-02-21-25-09-798.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org