jiridanek opened a new pull request, #394: URL: https://github.com/apache/qpid-proton/pull/394
MSVC apparently tried something to exclude 3rd party libs from strict compilation warning settings, https://devblogs.microsoft.com/cppblog/broken-warnings-theory/, and gcc/cmake should have this too, all IMPORTED targets include directories with -isystem, which should suppress excessive warnings https://stackoverflow.com/a/73549820/1047788.. [embarrassingly many minutes later] Aand, I think I found it, we have if (ENABLE_OPENTELEMETRYCPP) include_directories(${OPENTELEMETRY_CPP_INCLUDE_DIRS}) so we are preempting what I described above by pulling these dirs into the project on our own without CMake mediation! When this line (include_directories) is deleted, then the Clang build starts working. This change sillences compile errors such as ``` In file included from /home/jdanek/repos/qpid/qpid-proton/cmake-build-debug-clang/vcpkg_installed/x64-linux/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/invoke.h:42: /home/jdanek/repos/qpid/qpid-proton/cmake-build-debug-clang/vcpkg_installed/x64-linux/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/../../meta/type_traits.h:299:36: error: builtin __has_trivial_destructor is deprecated; use __is_trivially_destructible instead [-Werror,-Wdeprecated-builtins] : std::integral_constant<bool, __has_trivial_destructor(T) && ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
