gemmellr commented on code in PR #398: URL: https://github.com/apache/qpid-proton/pull/398#discussion_r1210174600
########## ci/otel.sh: ########## @@ -38,6 +38,6 @@ mkdir build cd build cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=ON -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DBUILD_TESTING=OFF -DWITH_OTLP=ON -DWITH_OTLP_HTTP=ON -DWITH_OTLP_GRPC=OFF Review Comment: Its setting WITH_OTLP, and also setting both WITH_OTLP_HTTP + WITH_OTLP_GRPC...the warnings seems like the latter two are replacement options, so can we just remove the first one now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
