[
https://issues.apache.org/jira/browse/QPID-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906857#action_12906857
]
Robbie Gemmell commented on QPID-2832:
--------------------------------------
Some comments would be helpful to indicate where multiple format strings are
used as a group, eg the 3 used for connection message formatting.
In the interests of consistency either the existing statics in the *LogSubject
classes should be reused instead of this change, or thost classes probably need
to be updated to statically import these definitions.This will help o ensure
the code remains properly maintainable.
> Collate all the LogSubject formatting strings in a static class
> ---------------------------------------------------------------
>
> Key: QPID-2832
> URL: https://issues.apache.org/jira/browse/QPID-2832
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Affects Versions: 0.7
> Reporter: Sorin Suciu
> Priority: Minor
> Fix For: 0.7
>
> Attachments: qpid-2832.patch
>
>
> It is useful to have all the LogSubject's formats in a separate class and
> static import them when/where needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
