[
https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803960#comment-17803960
]
ASF GitHub Bot commented on PROTON-2772:
----------------------------------------
jiridanek commented on PR #409:
URL: https://github.com/apache/qpid-proton/pull/409#issuecomment-1880060298
My plan here is to boot up Windows, add all the new warnings on MSVC to the
CMakeLists.txt as suppressed, and merge that. I will add comments what these
numbers mean. I'll consider putting this into a separate cmake file if the list
of suppressions becomes very long.
I imagine this might be hard to maintain if we ever wanted to do
warnings-as-errors on msvc, or if msvc then fails when compiling on an older
version which does not know some particular warning flag (gcc does this). I
will not try to do warnings-as-errors on MSVC to be sure.
> [c] Add parameter safety annotations for printf format strings
> --------------------------------------------------------------
>
> Key: PROTON-2772
> URL: https://issues.apache.org/jira/browse/PROTON-2772
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.39.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: proton-c-0.40.0
>
>
> There seem to be various mismatched printf format arguments. This is best
> resolved by annotating the string format parameters so that regular
> compilation warns on the mismatches as they happen.
> Proton already has some of this, but it is incomplete.
> {noformat}
> ```
> /home/jdanek/repos/qpid/qpid-proton/c/src/core/logger.c: In function
> ‘pni_logger_log_raw’:
> /home/jdanek/repos/qpid/qpid-proton/c/src/core/logger.c:204:41: error: format
> ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type
> ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]
> 204 | pn_fixed_string_addf(&out, "%04x/%04x: ", i, size);
> | ~~~^ ~~~~
> | | |
> | | size_t {aka long
> unsigned int}
> | unsigned int
> | %04lx
> cc1: all warnings being treated as errors
> ```
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
