[
https://issues.apache.org/jira/browse/QPID-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814369#comment-17814369
]
ASF GitHub Bot commented on QPID-8666:
--------------------------------------
dakirily commented on code in PR #238:
URL: https://github.com/apache/qpid-broker-j/pull/238#discussion_r1478308423
##########
broker-core/src/test/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecovererTest.java:
##########
@@ -121,9 +124,10 @@ public void
testUpgradeVirtualHostWithJDBCStoreAndHikariCPPool()
"qpid.jdbcstore.varBinaryType", "myvarbinary",
"qpid.jdbcstore.blobType", "myblob",
"qpid.jdbcstore.useBytesForBlob", true,
- "qpid.jdbcstore.hikaricp.maximumPoolSize", 7,
- "qpid.jdbcstore.hikaricp.minimumIdle", 6);
- final Map<String,Object> expectedAttributes =
Map.of("connectionPoolType", "HIKARICP",
+ "qpid.jdbcstore.bonecp.maxConnectionsPerPartition", 7,
+ "qpid.jdbcstore.bonecp.minConnectionsPerPartition", 6,
+ "qpid.jdbcstore.bonecp.partitionCount", 2);
+ final Map<String,Object> expectedAttributes =
Map.of("connectionPoolType", "BONECP",
Review Comment:
Hi Robbie,
[PR-239](https://github.com/apache/qpid-broker-j/pull/239) was created to
fix those issues.
> [Broker-J] Broker plugin jdbc-provider-bone replacement
> -------------------------------------------------------
>
> Key: QPID-8666
> URL: https://issues.apache.org/jira/browse/QPID-8666
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-9.1.0
> Reporter: Daniil Kirilyuk
> Priority: Major
> Fix For: qpid-java-broker-9.2.0
>
>
> Broker plugin jdbc-provider-bone relies on JDBC connection pooling library
> bonecp, which is no longer developed or updated. The [github project
> page|https://github.com/wwadge/bonecp] states:
> "BoneCP is a Java JDBC connection pool implementation that is tuned for high
> performance by minimizing lock contention to give greater throughput for your
> applications. It beats older connection pools such as C3P0 and DBCP but
> should now be considered deprecated in favour of HikariCP".
> Plugin jdbc-provider-bone should be replaced with the new one
> jdbc-provider-hikaricp based on
> [HikariCP|https://github.com/brettwooldridge/HikariCP] library. Both
> libraries use Apache-2.0 license.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
