[ 
https://issues.apache.org/jira/browse/PROTON-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815369#comment-17815369
 ] 

ASF GitHub Bot commented on PROTON-2438:
----------------------------------------

zlomek commented on code in PR #379:
URL: https://github.com/apache/qpid-proton/pull/379#discussion_r1481809556


##########
cpp/src/proactor_container_impl.cpp:
##########
@@ -532,7 +540,13 @@ void container::impl::run_timer_jobs() {
     // We've now taken the tasks to run from the deferred tasks
     // so we can run them unlocked
     // NB. We copied the due tasks in reverse order so execute from end
-    for (int i = tasks.size()-1; i>=0; --i) tasks[i].task();
+
+    for (int i = tasks.size()-1; i>=0; --i) {
+        if(is_active_.count(tasks[i].w_handle)) {
+            tasks[i].task();
+            is_active_.erase(tasks[i].w_handle);

Review Comment:
   Maybe, `is_active_` could be checked / modified while generating `tasks` 
vector in the critical section under `deferred_lock_` locked, and `tasks` then 
would contain only the active tasks?





> [cpp] Cancellable tasks
> -----------------------
>
>                 Key: PROTON-2438
>                 URL: https://issues.apache.org/jira/browse/PROTON-2438
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>            Reporter: Božo Dragojevič
>            Assignee: Rakhi Kumari
>            Priority: Major
>             Fix For: proton-c-0.38.0
>
>
> Allow scheduled tasks to be cancelled.
> A cancelled task does not keep reactor from stoping running



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to