[ 
https://issues.apache.org/jira/browse/PROTON-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820221#comment-17820221
 ] 

ASF subversion and git services commented on PROTON-2795:
---------------------------------------------------------

Commit b5ac05d77ce697d0290643709bb2f5d718a1a673 in qpid-protonj2's branch 
refs/heads/main from Timothy Bish
[ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=b5ac05d7 ]

PROTON-2795 Ensure message format is set on first transfer frame

Fix code to enforce send of message format on first transfer and omit
from subsequent frames as it is not needed after the first Transfer
frame.

> Message format cannot be set to 0 on outbound messages
> ------------------------------------------------------
>
>                 Key: PROTON-2795
>                 URL: https://issues.apache.org/jira/browse/PROTON-2795
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: protonj2
>    Affects Versions: protonj2-1.0.0-M19
>            Reporter: Arnaud Cogoluègnes
>            Assignee: Timothy A. Bish
>            Priority: Minor
>
> Setting the message format to 0 or keeping the default value results in a 
> null value in the {{transfer}} frame.
> 0 seems to be considered [a special 
> value|https://github.com/apache/qpid-protonj2/blob/d5144af7818b2695747782bacc410580d3ec7943/protonj2/src/main/java/org/apache/qpid/protonj2/engine/impl/ProtonSessionOutgoingWindow.java#L270-L274]
>  in the code.
> This contradicts [the 
> Javadoc|https://github.com/apache/qpid-protonj2/blob/d5144af7818b2695747782bacc410580d3ec7943/protonj2-client/src/main/java/org/apache/qpid/protonj2/client/AdvancedMessage.java#L170-L200]:
> {quote}This field MUST be specified for the first transfer of a 
> multi-transfer message, if it is not set at the time of send of the first 
> transfer the sender uses the AMQP default value of zero for this field.{quote}
> As well as the AMQP spec (section 2.7.5):
> {quote}This field MUST be specified for the first transfer of a 
> multi-transfer message and can only be omitted for continuation transfers. It 
> is an error if the message-format on a continuation transfer differs from the 
> message-format on the first transfer of a delivery.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to