astitcher commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1564414072
########## python/setup.cfg: ########## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the limit -max-line-length = 150 - -# TODO(PROTON-2322) re-enable all these warnings -ignore = - # do not use bare 'except' - E722, - # imported but unused - F401, - # ambiguous variable name 'l' - E741, - # local variable 'int_nodes' is assigned to but never used - F841, - # TODO(PROTON-2322) decide which of these two warnings we want disabled - # _transport.py:908:21: W503 line break before binary operator - # _transport.py:907:56: W504 line break after binary operator - W504, Review Comment: I rewrote the code to avoid using more than one line (and I think made it a little easier to understand) And in general it's avoidable if you're checking before committing the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
