[
https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906021#comment-17906021
]
ASF GitHub Bot commented on PROTON-1442:
----------------------------------------
DreamPearl commented on code in PR #437:
URL: https://github.com/apache/qpid-proton/pull/437#discussion_r1886778205
##########
cpp/src/container.cpp:
##########
@@ -28,6 +28,7 @@
#include "proton/uuid.hpp"
#include "proactor_container_impl.hpp"
+#include <vector>
Review Comment:
Removed!
##########
cpp/src/container.cpp:
##########
@@ -45,6 +46,10 @@ returned<connection> container::connect(const std::string
&url) {
return connect(url, connection_options());
}
+transaction container::declare_transaction(proton::connection conn,
proton::transaction_handler &handler, bool settle_before_discharge) {
+ return impl_->declare_transaction(conn, handler, settle_before_discharge);
+}
+
Review Comment:
Fixed!
> [c++] Support for transactions
> ------------------------------
>
> Key: PROTON-1442
> URL: https://issues.apache.org/jira/browse/PROTON-1442
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
> Reporter: Radim Kubis
> Assignee: Rakhi Kumari
> Priority: Major
>
> Support for transactions in Qpid Proton C++.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
