gemmellr commented on PR #250: URL: https://github.com/apache/qpid-broker-j/pull/250#issuecomment-2619209518
However you only opened the PR several hours _after_ Rob already pushed his own commit, as the timestamps show. That you had it locally earlier and planned to open a PR, is not something he could have known since you did not say so (or rather Ram who opened the Jira apparently for your efforts, without mentioning your PR would be coming). Sorry, but I'm not reverting a fairly trivial (even if impactful to your use case) change that _Rob did make himself_, just to then reapply your equivalent. Rob can burn his time unwinding his own change if he feels like it. If you want to contribute more changes that is great....but if you really care, even for small changes like this, that your PR/commit is the one to be pushed, you should make clear that such a PR/commit is coming _before someone else makes and pushes an equivalent change (because it doesnt look like a PR is coming), and then your commit will in fact be the one that ends up being pushed. Perhaps also raise your own Jiras for your PRs so you can time them, so that there isnt a large gap between commit and PR, if you have been working on changes that dont alreayd have a Jira. For Jiras that already exist before the fix is worked on, be sure to comment you are working on a change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
