Thanks for working on this cleanup, I've been a bit swamped and haven't had time to return to change the style or fix the logging. For what its worth, we've been using this in a major product release in system test for a few months, zero issues on the service to date...
On Mon, Sep 27, 2010 at 11:40 AM, Daniel Sack (JIRA) <qpid-...@incubator.apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/QPID-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Daniel Sack updated QPID-2519: > ------------------------------ > > Attachment: broker_as_service_Qpid_Logging.patch > > Hi, > Scince we need this patch for our production system, I tried to implement > parts of the comments > 1. Please reformat according to Qpid coding style > (http://qpid.apache.org/qpid-c-documentation.html) - no tabs, consistent > brace style > -> didn't have the time for it > > 2. There's a global WinService in QpiddBroker.cpp - what's that for? > -> Responsible for all the daemon stuff which is needed for the windows > platform. > > 3. Lots of printfs and no Qpid logging statements, and no exception throwing > on error. Please review these and probably should be throwing on errors; > outputs should probably be using logging to be redirected as the user > specified. > -> triedto fix this > >> Allow Windows Broker to run as a Service >> ---------------------------------------- >> >> Key: QPID-2519 >> URL: https://issues.apache.org/jira/browse/QPID-2519 >> Project: Qpid >> Issue Type: New Feature >> Components: C++ Broker >> Reporter: Kerry Bonin >> Attachments: broker_as_service_Qpid_Logging.patch, >> broker_as_service_r921371.patch >> >> >> The Windows version of the C++ Broker should have the ability to run as a >> Windows Service, to correspond with the ability of the *nix version to run >> as a daemon, as this is a common requirement for critical software >> infrastructure elements of enterprise class software on the Windows platform. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:dev-subscr...@qpid.apache.org > > --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
