stephenb-work opened a new pull request, #441:
URL: https://github.com/apache/qpid-proton/pull/441

   [JIRA](https://issues.apache.org/jira/browse/PROTON-2907)
   
   Ruby binding is broken for projects using a recent URI gem version. For me 
it broke with ruby 3.3.6 and URI 1.0.3.
   
   This fix replaces the ruby version check with a check on what the 
`URI::DEFAULT_PARSER` is. If it is `Rfc3986Parser`, we then explicitly use the 
other parser. Earlier ruby/URI versions do not have separate classes for 
parsers, it was just `Parser`. And that is why this is explicitly checking for 
the new one, versus checking if `URI::DEFAULT_PARSER` is `Rfc2396Parser`.
   
   Note: The RUBY_VERSION check was added in this previous MR: 
https://github.com/apache/qpid-proton/pull/439


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to