[ 
https://issues.apache.org/jira/browse/PROTON-2912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arnaud Cogoluègnes updated PROTON-2912:
---------------------------------------
    Description: 
The field is not 
[updated|https://github.com/apache/qpid-protonj2/blob/a7f60afaa391094e7f998b64e4235839609474c9/protonj2-client/src/main/java/org/apache/qpid/protonj2/client/impl/ClientDeliveryState.java#L191],
 the argument is instead:
{code:java}
ClientRejected(Rejected rejected) {
  if (rejected.getError() != null) {
    rejected.setError(rejected.getError().copy());
  }
}
{code}
Should be:
{code:java}
ClientRejected(Rejected rejected) {
  if (rejected.getError() != null) {
    this.rejected.setError(rejected.getError().copy());
  }
}
{code}

  was:
The property is not 
[updated|https://github.com/apache/qpid-protonj2/blob/a7f60afaa391094e7f998b64e4235839609474c9/protonj2-client/src/main/java/org/apache/qpid/protonj2/client/impl/ClientDeliveryState.java#L191],
 the argument is instead:

{code:java}
ClientRejected(Rejected rejected) {
  if (rejected.getError() != null) {
    rejected.setError(rejected.getError().copy());
  }
}
{code}

Should be:

{code:java}
ClientRejected(Rejected rejected) {
  if (rejected.getError() != null) {
    this.rejected.setError(rejected.getError().copy());
  }
}
{code}


> ClientRejected constructor updates parameter instead of field
> -------------------------------------------------------------
>
>                 Key: PROTON-2912
>                 URL: https://issues.apache.org/jira/browse/PROTON-2912
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: protonj2
>    Affects Versions: protonj2-1.0.0
>            Reporter: Arnaud Cogoluègnes
>            Assignee: Timothy A. Bish
>            Priority: Minor
>
> The field is not 
> [updated|https://github.com/apache/qpid-protonj2/blob/a7f60afaa391094e7f998b64e4235839609474c9/protonj2-client/src/main/java/org/apache/qpid/protonj2/client/impl/ClientDeliveryState.java#L191],
>  the argument is instead:
> {code:java}
> ClientRejected(Rejected rejected) {
>   if (rejected.getError() != null) {
>     rejected.setError(rejected.getError().copy());
>   }
> }
> {code}
> Should be:
> {code:java}
> ClientRejected(Rejected rejected) {
>   if (rejected.getError() != null) {
>     this.rejected.setError(rejected.getError().copy());
>   }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to