[
https://issues.apache.org/jira/browse/PROTON-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069794#comment-18069794
]
ASF GitHub Bot commented on PROTON-2331:
----------------------------------------
codecov-commenter commented on PR #297:
URL: https://github.com/apache/qpid-proton/pull/297#issuecomment-4160240926
##
[Codecov](https://app.codecov.io/gh/apache/qpid-proton/pull/297?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 67.80%. Comparing base
([`ebd301b`](https://app.codecov.io/gh/apache/qpid-proton/commit/ebd301b954e91e75ebdfd19316ca45ea3de9e146?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`372eb95`](https://app.codecov.io/gh/apache/qpid-proton/commit/372eb954837aaea1148cc95bfd247d57a26ae3d7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 502 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #297 +/- ##
==========================================
- Coverage 68.98% 67.80% -1.18%
==========================================
Files 351 353 +2
Lines 69121 69218 +97
==========================================
- Hits 47682 46936 -746
- Misses 21439 22282 +843
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/qpid-proton/pull/297?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
</details>
> Allow producing a RelWithDebInfo build with asserts enabled
> -----------------------------------------------------------
>
> Key: PROTON-2331
> URL: https://issues.apache.org/jira/browse/PROTON-2331
> Project: Qpid Proton
> Issue Type: Improvement
> Components: build, proton-c
> Affects Versions: proton-c-0.33.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
>
> The LLVM project has a CMake option which enables asserts in C code in any
> build type, including RelWithDebInfo, etc. This seems like an useful thing to
> have.
> It can reduce number of builds needed in CI (we don't have a Debug build for
> MacOS now). Some bugs may only manifest in Release builds. Sanitizers run
> faster on Release builds.
> Coverity warns about assert calls with side effects, so enabling asserts all
> the time should be safe (Coverity would scream if it had any effects on
> functionality).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
