[ 
https://issues.apache.org/jira/browse/DISPATCH-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070534#comment-18070534
 ] 

ASF GitHub Bot commented on DISPATCH-2199:
------------------------------------------

codecov-commenter commented on PR #1300:
URL: https://github.com/apache/qpid-dispatch/pull/1300#issuecomment-4175685083

   ## 
[Codecov](https://app.codecov.io/gh/apache/qpid-dispatch/pull/1300?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 84.65%. Comparing base 
([`b1c25e9`](https://app.codecov.io/gh/apache/qpid-dispatch/commit/b1c25e94c76926c35ee48ced4053abfc23fdf347?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`d03fcb6`](https://app.codecov.io/gh/apache/qpid-dispatch/commit/d03fcb641d87fa6bb34b9c8757048fa10ae33951?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 229 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1300      +/-   ##
   ==========================================
   + Coverage   84.60%   84.65%   +0.05%     
   ==========================================
     Files         113      113              
     Lines       28326    28326              
   ==========================================
   + Hits        23965    23980      +15     
   + Misses       4361     4346      -15     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/qpid-dispatch/pull/1300?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Cleanup_link code in container.c does not use safe_ptr properly
> ---------------------------------------------------------------
>
>                 Key: DISPATCH-2199
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2199
>             Project: Qpid Dispatch
>          Issue Type: Test
>          Components: Router Node
>    Affects Versions: 1.16.1
>            Reporter: Charles E. Rolke
>            Assignee: Charles E. Rolke
>            Priority: Major
>             Fix For: 1.17.0
>
>
> This code manually performs the function of public interface 
> qd_alloc_deref_safe_ptr() .
> {code:java}
>         // cleanup any inbound message that has not been forwarded
>         qd_message_t *msg = link->incoming_msg.ptr;
>         if (msg && qd_alloc_sequence(msg) == link->incoming_msg.seq)
>             qd_message_free(msg);
> {code} 
> Modifications to qd_alloc_deref_safe_ptr are not applied to this code block 
> and will spoil research efforts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to