[
https://issues.apache.org/jira/browse/PROTON-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070865#comment-18070865
] ASF GitHub Bot commented on PROTON-2407: ---------------------------------------- codecov-commenter commented on PR #326: URL: https://github.com/apache/qpid-proton/pull/326#issuecomment-4184073966 ## [Codecov](https://app.codecov.io/gh/apache/qpid-proton/pull/326?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `91.20879%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.67%. Comparing base ([`2ed7966`](https://app.codecov.io/gh/apache/qpid-proton/commit/2ed7966fa4f4e9c200622ea7cd31ca2cd6a5b5fb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e06678b`](https://app.codecov.io/gh/apache/qpid-proton/commit/e06678b0cde51832e0c030789d04e2681aee21f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 441 commits behind head on main. | [Files with missing lines](https://app.codecov.io/gh/apache/qpid-proton/pull/326?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [python/proton/\_utils.py](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&filepath=python%2Fproton%2F_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHl0aG9uL3Byb3Rvbi9fdXRpbHMucHk=) | 76.92% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [python/proton/\_condition.py](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&filepath=python%2Fproton%2F_condition.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHl0aG9uL3Byb3Rvbi9fY29uZGl0aW9uLnB5) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [python/proton/\_handlers.py](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&filepath=python%2Fproton%2F_handlers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHl0aG9uL3Byb3Rvbi9faGFuZGxlcnMucHk=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [python/proton/\_message.py](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&filepath=python%2Fproton%2F_message.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHl0aG9uL3Byb3Rvbi9fbWVzc2FnZS5weQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [python/proton/\_reactor.py](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&filepath=python%2Fproton%2F_reactor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHl0aG9uL3Byb3Rvbi9fcmVhY3Rvci5weQ==) | 96.96% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [python/proton/\_selectable.py](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&filepath=python%2Fproton%2F_selectable.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHl0aG9uL3Byb3Rvbi9fc2VsZWN0YWJsZS5weQ==) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/qpid-proton/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## main #326 +/- ## ======================================= Coverage 68.66% 68.67% ======================================= Files 351 351 Lines 70469 70484 +15 ======================================= + Hits 48386 48403 +17 + Misses 22083 22081 -2 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/qpid-proton/pull/326?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details> > [proton-python] add type annotations > ------------------------------------ > > Key: PROTON-2407 > URL: https://issues.apache.org/jira/browse/PROTON-2407 > Project: Qpid Proton > Issue Type: New Feature > Components: python-binding > Affects Versions: proton-c-0.35.0 > Reporter: Jiri Daněk > Assignee: Jiri Daněk > Priority: Major > Fix For: proton-c-0.36.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
