[
https://issues.apache.org/jira/browse/DISPATCH-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071065#comment-18071065
]
ASF GitHub Bot commented on DISPATCH-1582:
------------------------------------------
codecov-commenter commented on PR #697:
URL: https://github.com/apache/qpid-dispatch/pull/697#issuecomment-4187261137
##
[Codecov](https://app.codecov.io/gh/apache/qpid-dispatch/pull/697?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `66.66667%` with `7 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 86.82%. Comparing base
([`6d7b421`](https://app.codecov.io/gh/apache/qpid-dispatch/commit/6d7b4219055da30404a0ebbaddb350febb0275b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`d239721`](https://app.codecov.io/gh/apache/qpid-dispatch/commit/d239721bad68d7ca84c2a7eef4bedc4345c03755?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/qpid-dispatch/pull/697?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[src/router\_core/modules/mobile\_sync/mobile.c](https://app.codecov.io/gh/apache/qpid-dispatch/pull/697?src=pr&el=tree&filepath=src%2Frouter_core%2Fmodules%2Fmobile_sync%2Fmobile.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvbW9iaWxlX3N5bmMvbW9iaWxlLmM=)
| 66.66% | [7 Missing :warning:
](https://app.codecov.io/gh/apache/qpid-dispatch/pull/697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 86.89% 86.82% -0.08%
==========================================
Files 93 93
Lines 21208 21228 +20
==========================================
+ Hits 18429 18431 +2
- Misses 2779 2797 +18
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/qpid-dispatch/pull/697?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Prepare Routing Protocol for Backward Compatibility
> ---------------------------------------------------
>
> Key: DISPATCH-1582
> URL: https://issues.apache.org/jira/browse/DISPATCH-1582
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Minor
> Fix For: 1.11.0
>
>
> In anticipation of moving to routing protocol version 2 (we're currently on
> 1), there are a few changes needed to make it easy for version 2 to be
> backward compatible to version 1. This Jira will track those changes.
> The proposed change is to ensure that a version 1 router ignores version >1
> messages, issuing a low-volume warning log when one is received. This way, a
> version 2 router can send both versions or send targeted versions based on
> its knowledge of peer routers protocol versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
