[ 
https://issues.apache.org/jira/browse/PROTON-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072024#comment-18072024
 ] 

ASF GitHub Bot commented on PROTON-2217:
----------------------------------------

codecov-commenter commented on PR #294:
URL: https://github.com/apache/qpid-proton/pull/294#issuecomment-4207777678

   ## 
[Codecov](https://app.codecov.io/gh/apache/qpid-proton/pull/294?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.84%. Comparing base 
([`e4f3c34`](https://app.codecov.io/gh/apache/qpid-proton/commit/e4f3c34396c798529b35fadf93ba57b771aadebf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`5101c73`](https://app.codecov.io/gh/apache/qpid-proton/commit/5101c73e8a0265fd7bdf7006b113271bb321df59?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #294      +/-   ##
   ==========================================
   - Coverage   69.06%   67.84%   -1.22%     
   ==========================================
     Files         353      353              
     Lines       69213    69214       +1     
   ==========================================
   - Hits        47800    46958     -842     
   - Misses      21413    22256     +843     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/qpid-proton/pull/294?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   </details>




> Python detection logic prefers python2 over python3 when both are installed
> ---------------------------------------------------------------------------
>
>                 Key: PROTON-2217
>                 URL: https://issues.apache.org/jira/browse/PROTON-2217
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: build, proton-c, python-binding
>    Affects Versions: proton-c-0.31.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>             Fix For: proton-c-0.34.0
>
>
> I have the same experience that was reported elsewhere:
> bq. For me, the find_package(PythonInterp) call was always finding the older 
> interpreter (2.7) even though everything pointed to the newer one (3.6). 
> (from https://reviews.llvm.org/D64881)
> This behavior is unfortunate on Ubuntu 20.04 Focal, where both python2 and 
> python3 are available, but pip for python2 is not packaged. Therefore it 
> makes sense to build proton with python3; which would make sense anyways, 
> since Python 2.7 is deprecated by the Python Software Foundation nowadays..
> Besides removing python2 as discussed on the linked page, there is currently 
> nicer way to force python3 that worked for me, by setting 
> {{-DPYTHON_EXECUTABLE=/usr/bin/python3}} CMake variable.
> Related dispatch issue, DISPATCH-187



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to