[
https://issues.apache.org/jira/browse/QPIDJMS-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18086296#comment-18086296
]
ASF GitHub Bot commented on QPIDJMS-624:
----------------------------------------
davidvoit commented on code in PR #61:
URL: https://github.com/apache/qpid-jms/pull/61#discussion_r3361530507
##########
qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelperTest.java:
##########
@@ -688,6 +689,34 @@ public void
testGetJmsReplToWithLegacyTempTopicTypeAnnotationNoConsumerDestinati
assertEquals(testAddress, destination.getAddress());
}
+ @Test
+ public void
doGetJmsReplToWithTempQueueUnsignedByteTypeAnnotationTestImpl() throws
Exception {
Review Comment:
Sorry this was copy paste error I think I copied another fragment before as
a reference, this should hopefully be now fixed. If you have a better name just
let me know :-)
> AMQP JMS Binding Type Annotations should also support non-byte datatypes
> ------------------------------------------------------------------------
>
> Key: QPIDJMS-624
> URL: https://issues.apache.org/jira/browse/QPIDJMS-624
> Project: Qpid JMS
> Issue Type: Improvement
> Reporter: David Voit
> Priority: Minor
>
> In the AMQP JMS spec Type Annotations are definied to be of byte type.
> NMS AMQP had a bug which was sending these annotation as an unsigned byte.
> This is a bug in NMS Amqp. But the spec also says that a conforming
> implementation on the recieving side, should support all numeric data types,
> not just signed bytes.
> It will take some time to fix all nms amqp clients to switch to an release
> (which not yet even happened) which no longer has this problem. Also this
> change also makes the code more error resilant, and the change is quite
> trivial
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
