[
https://issues.apache.org/jira/browse/PROTON-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18102499#comment-18102499
]
ASF subversion and git services commented on PROTON-2946:
---------------------------------------------------------
Commit f41881d6be1b59f7de370b1a21d6a9885a0cc22b in qpid-proton's branch
refs/heads/main from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=f41881d6b ]
PROTON-2946: Fix interop round trip comparison to be semantic
Previously we used a byte for byte comparison but it is legitimate to encode
using small encodings where the value will fit even if the bytes decoded used a
large encoding.
> Interop round trip tests should use a semantic comparison
> ---------------------------------------------------------
>
> Key: PROTON-2946
> URL: https://issues.apache.org/jira/browse/PROTON-2946
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.40.0
> Reporter: Andrew Stitcher
> Assignee: Andrew Stitcher
> Priority: Major
> Fix For: proton-c-0.41.0
>
>
> There are multiple correct on-the-wire encodings of lists, arrays, maps,
> strings and bytes for the same data if the size fits in 255 bytes. The
> current interop round trip doesn't take into account that an input large
> encoding could encode to a small encoding if it has few enough elements and
> is small enough.
> We'll check this by creating a canonical text representation of both input
> and output and comparing them instead of the raw bytes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
