[
https://issues.apache.org/jira/browse/QPID-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920603#action_12920603
]
Chuck Rolke commented on QPID-2905:
-----------------------------------
This patch does a decent job of the MinGW port.
The only question I have is on patch line 992: Why does the cpp/CMakeLists file
need a Boost_COMPILER setting? Further, is there any down side to setting the
value to -gcc44 when compiling under MSVC? Could this be made conditional on
MinGW builds (unless, of course, it's harmless)?
It's almost time for a Conditional Variable Scoreboard. CMake uses MSVC, WIN32,
and MSVC80. C++ uses _MSC_VER, _WINDOWS, and WIN32. Exactly how these are used
and overloaded becomes less clear with this patch.
> Fixes for mingw cross-compilation (C++)
> ---------------------------------------
>
> Key: QPID-2905
> URL: https://issues.apache.org/jira/browse/QPID-2905
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker, C++ Client, Code Generator
> Affects Versions: 0.7
> Reporter: Ted Ross
> Assignee: Ted Ross
> Fix For: 0.7
>
> Attachments: cross2.diff
>
>
> In attempting to cross-compile the Qpid trunk in the MinGW environment, a
> number of build errors were seen. Attached to this issue is a patch that
> fixes the errors and builds cleanly on Linux/gcc and MS Visual Studio as well.
> The classes of error discovered are:
> 1) Case-sensitivity of file names (i.e. Secure32.lib => secure32.lib)
> 2) Syntax issues where MSVC is too lenient (semicolon after the closing brace
> of a template function)
> 3) *_EXTERN on DLL APIs. MinGW doesn't like externs on in-line functions,
> requires externs on class names.
> 4) const_case<char*>() needed on LPTSTR arguments in the Windows API
> 5) Unused function arguments need to be commented out
> 6) the *_s variants of ::localtime, ::strncpy, ::strerror can't be used
> Before I commit, I would appreciate some review and feedback on this patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
