ansd commented on PR #73: URL: https://github.com/apache/qpid-jms/pull/73#issuecomment-5568932350
Thank you @gemmellr for your reply. Two specifications unambiguously state that the current Qpid JMS client behaviour is a bug: 1. https://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#section-message-format clearly states "zero or one" section for all non-body sections and requires at least one section for the body. 2. The [AMQP JMS mapping spec](https://groups.oasis-open.org/higherlogic/ws/public/download/67638/amqp-bindmap-jms-v1.0-wd10.pdf/latest) explains in section 3.2.4 how the different JMS body types map to AMQP 1.0 messages. For this issue, section 3.2.4.7 is the relevant one and unambiguously states that such a message must have a single `amqp-value` section containing `null`. This is additionally confirmed in Figure 3.9. > so I would actually instead suggest you make RabbitMQ tolerate this instead of giving a decode error. If there is a bug in the client, the client should be fixed, not the server. > Either way, I would likely not implement it the way it has been here as a side effect of the AmqpCodec class, but within the message objects themselves. Ok, please let us know if you want us to change this. > It would also need a Jira. Ok, I created a Jira: https://issues.apache.org/jira/browse/QPIDJMS-633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
