gemmellr commented on PR #76: URL: https://github.com/apache/qpid-jms/pull/76#issuecomment-5569536819
To begin, we dont consider this a bug as you have described it to be. It is long known behaviour and at the time was quite deliberate, hence the existing tests related behaviour. Prefetch as a concept is something that largely sits outwith what JMS covers, e.g multi-consumer ordering and priority handling are things it interacts with heavily but nothing is said to that. The client has configuration to adjust its prefetch behaviour and applications are expected to set it according to their specific needs if the default isnt to their specific needs/liking. That would apply here just as much, for example you could disable prefetch for your TCK runs by configuring it to 0. Even if still considering this as an improvement, I'll need some time to fully consider the code and behaviour change, but skimming it I see you modified lots of tests to start the connection and say '// Consumers only get link credit once the connection is started.' even though I guess from the names many of those tests never needed or intended to transfer messages. It may be nicer to remove the expectation for a flow in such cases instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
