[ 
https://issues.apache.org/jira/browse/PROTON-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18123950#comment-18123950
 ] 

ASF subversion and git services commented on PROTON-2956:
---------------------------------------------------------

Commit 7ef957115006b73c51f0aff0868e8144fb71adad in qpid-protonj2's branch 
refs/heads/1.x from Daniil Kirilyuk
[ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=7ef95711 ]

PROTON-2956 Delivery tag at pool index 256 is not unique

(cherry picked from commit 159bad569405482cf0d80395400f533a1f5f647c)


> [protonj2] Pooled delivery-tag generator emits duplicate tags when more than 
> 256 tags are checked out
> -----------------------------------------------------------------------------------------------------
>
>                 Key: PROTON-2956
>                 URL: https://issues.apache.org/jira/browse/PROTON-2956
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: protonj2
>    Affects Versions: protonj2-1.3.0
>            Reporter: Daniil Kirilyuk
>            Assignee: Timothy A. Bish
>            Priority: Minor
>             Fix For: protonj2-1.4.0
>
>
> {{ProtonPooledTagGenerator}} has a default pool size of 512, but truncates 
> each pooled tag ID to a Java {{byte}} when constructing the tag:
> {code:java}
> new ProtonPooledDeliveryTag((byte) nextTagId++).checkOut();{code}
> This produces only 256 distinct AMQP delivery-tag byte values.
> When sending pressure causes more than 256 pooled tags to be checked out 
> concurrently, ProtonJ2 can therefore send a new delivery using the same tag 
> as an existing unsettled delivery.
> AMQP 1.0 requires a delivery tag to be unique among all deliveries that 
> either end of the link could consider unsettled. A conforming peer can 
> consequently detach the link with {_}Delivery-tag 'X' is used by another 
> unsettled delivery{_}.
> This seems to be the root cause of QPID-8599.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to