[ 
https://issues.apache.org/jira/browse/QPID-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marnie McCormack resolved QPID-2980.
------------------------------------

    Resolution: Fixed

Review of commits to branch, comments/questions are:

1. BasicMessageConsumer.preDeliver
? In case stmt, should dups ok ack mode not execute the call to recordMessageID 
? Thought it possibly should ?

2. BasicMessageConsumer.recordMessageID
Not a biggie, but possible log if msgId == null here (or in DCT.recordMessage) 
as something gone very wrong if it is null.

Aside from that looks good, and a good use of LinkedHashMap ordering for the 
cache ! 

> expose the delivery count as a property
> ---------------------------------------
>
>                 Key: QPID-2980
>                 URL: https://issues.apache.org/jira/browse/QPID-2980
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Client
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.9
>
>
> expose the delivery count being maintained by the client in order to reject 
> messages without requeue during rollback/recover once when they breach the 
> defined limit. The JMSXDeliveryCount property will be used to convey the 
> information.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Reply via email to