-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/833/
-----------------------------------------------------------
Review request for qpid.
Summary
-------
As mentioned in the JIRA a simple solution is to not notify via the exception
listener if a JMS exception can be directly thrown to the application.
The attached patch (unpolished) makes use of the sync call to determine if an
application can be notified directly or not.
If it is then it will not notify via the connection listener.
Andrew Kennedy had done some work previously to introduce a sync method in
AMQSession_0_10.java to facilitate sync calls.
This patch builds on top of it to provide the above functionality.
This patch also fixes issues like QPID-3259 and avoids other potential locking
issues due to the two ways(paths) of notifying the same error.
Please note this patch only affects the 0-10 code path.
This addresses bug QPID-3289.
https://issues.apache.org/jira/browse/QPID-3289
Diffs
-----
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java
1129752
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
1129752
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java
1129752
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Session.java
1129752
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/SessionDelegate.java
1129752
Diff: https://reviews.apache.org/r/833/diff
Testing
-------
Thanks,
rajith
