-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/850/
-----------------------------------------------------------

(Updated 2011-06-03 13:33:38.095512)


Review request for qpid, Alan Conway, Gordon Sim, and Ted Ross.


Summary
-------

1. Check client/server properties for presence of federationPeerTag, only set 
the tag if present.

2. Deprecate the use of federationLink flag, relying instead on non-zero length 
of federationPeerTag. The flag has been kept in place for QMF backwards 
compatibility.

3. Added a new flag ConnectionState::userProxyAuth which when set indicates 
that a node is authorized to proxy for its users on other nodes. The idea is to 
eventually have this authorization checked in ACL before setting it, but 
currently clustering uses this to proxy messages for users not on cluster nodes 
during cluster node updating. Previously clustering was setting the connection 
to look like a federation link to achieve this behaviour (using the deprecated 
flag), but this is a brittle implementation which adds dependencies and 
possibly complex behaviour in unrelated functionality.


Diffs
-----

  trunk/qpid/cpp/src/qpid/broker/Connection.h 1130619 
  trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1130619 
  trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1130619 
  trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1130619 
  trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1130619 
  trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1130619 
  trunk/qpid/specs/management-schema.xml 1130619 

Diff: https://reviews.apache.org/r/850/diff


Testing (updated)
-------

All current make check tests pass.


Thanks,

Kim

Reply via email to