-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/441/
-----------------------------------------------------------
(Updated 2011-07-14 22:39:37.941135)
Review request for qpid, Gordon Sim, Andrew Kennedy, Robbie Gemmell, rajith
attapattu, and Weston Price.
Changes
-------
- Addresses review comments from Andrew Kennedy
- Adds a bunch of examples and documentation
- Removes author (and some other) comments tags imported with code
- Bug fixes found through testing
- Updated Serialization UIDs (for changes since code import)
I intend this to be the code checked into qpid, so review would be welcome.
Summary
-------
Review for a qpid JCA resource adapter.
So far no build infrastructure is included.
I'd also like an opinion as to whether java/jca is the appropriate name for
this (I'm thinking perhaps java/ra would be more usual).
Any and all comments welcome.
This addresses bug QPID-3044.
https://issues.apache.org/jira/browse/QPID-3044
Diffs (updated)
-----
/trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
/trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidConnectionFactoryProxy.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidDestinationProxy.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidQueue.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidTopic.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/AdminObjectFactory.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidBindingURL.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueBrowser.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java
PRE-CREATION
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java
PRE-CREATION
/trunk/qpid/java/jca/example/src/qpid/jca/example/web/QpidTestServlet.java
PRE-CREATION
/trunk/qpid/java/jca/qpid-jca-ds.xml PRE-CREATION
/trunk/qpid/java/jca/example/conf/application.xml PRE-CREATION
/trunk/qpid/java/jca/example/conf/qpid-jca-ds.xml PRE-CREATION
/trunk/qpid/java/jca/example/conf/web.xml PRE-CREATION
/trunk/qpid/java/jca/example/src/qpid/jca/example/QpidClient.java
PRE-CREATION
/trunk/qpid/java/jca/example/src/qpid/jca/example/QpidStandaloneClient.java
PRE-CREATION
/trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidListener.java
PRE-CREATION
/trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidTest.java
PRE-CREATION
/trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidTestBean.java
PRE-CREATION
/trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidTestLocal.java
PRE-CREATION
/trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidTestRemote.java
PRE-CREATION
/trunk/qpid/java/build.deps 1070497
/trunk/qpid/java/build.xml 1070497
/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQQueueBrowser.java
1070497
/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/TopicPublisherAdapter.java
1070497
/trunk/qpid/java/eclipse-projects/.gitignore PRE-CREATION
/trunk/qpid/java/jca/README-JBOSS.txt PRE-CREATION
/trunk/qpid/java/jca/README.txt PRE-CREATION
/trunk/qpid/java/jca/build.xml PRE-CREATION
/trunk/qpid/java/jca/example/.gitignore PRE-CREATION
/trunk/qpid/java/jca/example/README PRE-CREATION
/trunk/qpid/java/jca/example/build.xml PRE-CREATION
Diff: https://reviews.apache.org/r/441/diff
Testing (updated)
-------
This code is now substantially the same as tested by Red Hat, passes the TCK.
Thanks,
Andrew
