[
https://issues.apache.org/jira/browse/QPID-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070993#comment-13070993
]
Srinath Perera commented on QPID-3319:
--------------------------------------
Hi Robbie,
Sorry, I have been traveling for 3 weeks and did not get to look at this.
I removed the synchronization from add/ remove etc. Sorry, I did not understood
how we can improve the size() method in the SubscriptionList.
I moved the findNextNode() to subscription list.
I fixed the styles .. let me know if there are any other problems I miss.
I have added a patch with above changes to the jira (QPID-3319-26-07-2011.patch)
Current implementation have a lingering memory leak, and if we have someone who
can understand and fix the memory leak, then I am all for fixing it. But if
there is none who can fix it reasonably fast, IMHO we should apply the stable
proposed fix as memory leak make Qpid pretty unusable. May be we can apply the
patch as a temporary fix if someone will work on fixing the memory leak.
I will write and add a Unit test to the SubscriptionList class, given that you
are OK with applying the patch. However, it is hard to check the memory leak
through a Unit Test as it take hours to create the problem. But I can add
functionality tests.
--Srinath
> org.apache.qpid.server.subscription.SubscriptionList leaks memory
> -----------------------------------------------------------------
>
> Key: QPID-3319
> URL: https://issues.apache.org/jira/browse/QPID-3319
> Project: Qpid
> Issue Type: Bug
> Reporter: Danushka Menikkumbura
> Assignee: Robbie Gemmell
> Priority: Critical
> Attachments: QPID-3319-26-07-2011.patch, QPID-3319.2.patch,
> QPID-3319.3.patch, QPID-3319.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
