[ 
https://issues.apache.org/jira/browse/QPID-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095515#comment-13095515
 ] 

[email protected] commented on QPID-3346:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1690/#review1725
-----------------------------------------------------------



/branches/qpid-3346/qpid/cpp/src/qpid/broker/Consumer.h
<https://reviews.apache.org/r/1690/#comment3936>

    Possibly - if the order of consumers in my container doesn't matter: think 
state replication across a cluster (I got burned by that exact issue before - 
different addresses caused ordering inconsistencies).  
    
    I think order doesn't matter - I'll give this a try as it would clean 
things up a bit.



/branches/qpid-3346/qpid/cpp/src/qpid/broker/Consumer.h
<https://reviews.apache.org/r/1690/#comment3937>

    Oops - actually, this diff doesn't show that I -introduced- this member on 
this branch awhile back.  Originally, I removed the private "tag" from 
ConsumerImpl and replaced it with the "name" in the base class (so clients 
could be referred to by name).
    
    Per Gordon's comment, I'm going to try to revert these consumer changes 
(restore the trunk version) if possible.  Stay tuned....


- Kenneth


On 2011-08-31 20:37:49, Kenneth Giusti wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1690/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-31 20:37:49)
bq.  
bq.  
bq.  Review request for qpid.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Update to message group development:
bq.  
bq.  Created a functional test tool that verifies message group behavior across 
multiple clients consuming from a single queue.
bq.  
bq.  Also, bugfix: the "tag" used to identify a Consumer is not unique beyond 
the consumer's session.  Queue's need to track consumers across different 
sessions, and using the tag was not unique enough.  I've introduced a consumer 
name that is generated on the broker and should be unique broker-wide.
bq.  
bq.  
bq.  This addresses bug qpid-3346.
bq.      https://issues.apache.org/jira/browse/qpid-3346
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Consumer.h 1158073 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.h 1158073 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.cpp 1158073 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1158073 
bq.    /branches/qpid-3346/qpid/cpp/src/tests/Makefile.am 1158073 
bq.    /branches/qpid-3346/qpid/cpp/src/tests/msg_group_test.cpp PRE-CREATION 
bq.    /branches/qpid-3346/qpid/cpp/src/tests/run_msg_group_tests PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1690/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  One simple functional test as an example - will flesh out the test script 
with multiple runs of the tool with different consumer and producer settings.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kenneth
bq.  
bq.



> Support message grouping with stricted sequence consumption across multiple 
> consumers.
> --------------------------------------------------------------------------------------
>
>                 Key: QPID-3346
>                 URL: https://issues.apache.org/jira/browse/QPID-3346
>             Project: Qpid
>          Issue Type: New Feature
>          Components: C++ Broker
>    Affects Versions: 0.12
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>             Fix For: 0.14
>
>         Attachments: UI.txt, msg_groups_0.2.txt
>
>
> This feature is described in the attached QIP as Policy #2: Sequenced 
> Consumers.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to