[
https://issues.apache.org/jira/browse/QPID-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117151#comment-13117151
]
Robbie Gemmell commented on QPID-3513:
--------------------------------------
Looks good to me, have a couple of tiny notes relating to the cpp.testprofile
file:
Spurious licence header change:
-# Unless required by applicable law or agreed to in writing,
+# unless required by applicable law or agreed to in writing,
The @PORT and data elements of the new data-dir path should be swapped to make
it use the same default value for the path as it did before. Could probably use
${build}/work in there instead also:
-broker.command=${broker.executable} -p @PORT --data-dir ${build.data}/@PORT -t
--auth no --no-module-dir ${broker.modules} ${broker.args}
+broker.command=${broker.executable} -p @PORT --data-dir
${project.root}/build/work/@PORT/data -t --auth no --no-module-dir
${broker.modules} ${broker.args}
> Avoid use of shell script clean-dir during test cycle
> -----------------------------------------------------
>
> Key: QPID-3513
> URL: https://issues.apache.org/jira/browse/QPID-3513
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.13
>
> Attachments:
> 0001-QPID-3513-Avoid-use-of-shell-script-clean-dir-during.patch
>
>
> Current the test harness provided by QpidBrokerTestCase utilises a UNIX shell
> script clean-dir to clean the broker's work
> directory. This approach is less than ideal: spawning a separate process is
> relativity slow and this delays the test cycle, it presents
> a barrier to running the test suite on Windows, and the approach is very
> sensitive to spaces within directory names (something that is preventing our
> use of Jenkins' matrix feature).
> This change will remove the use of the shellscript and replace with the
> existing FileUtils.delete utility method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
