----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2364/ -----------------------------------------------------------
(Updated 2011-10-12 21:09:40.553855) Review request for qpid, Gordon Sim, Robbie Gemmell, Weston Price, and Keith Wall. Summary ------- The following is a patch that illustrates the changes made to the core client namely the session, message consumer and producer classes. (Please note that in order to compile and run the tests you need to get apply the QPID-3401.patch attached to the JIRA.) Most of the code removed from the AMQSession_0_10.java have been included in the new class structure posted as a separate review [ https://reviews.apache.org/r/2366/ ] to ensure clarity. In summary the changes are, 1. The code now uses AddressBasedDestination if the syntax is ADDR. 2. For address destinations the code now delegates the creation, assertion, deletion actions to the underlying QpidDestination class via the AddressBasedDestination. 3. The code also delegates creating of subscriptions. TODO. 1. Delegate the deleting of subscriptions (minor change which will follow once this patch is approved) 2. Currently Durable Subscribers want work with AddressBasedDestinations (This will be done in a follow up patch that will be posted soon). (AddressBasedDestination, AddressBasedTopic and AddressBasedQueue classes are included along with the new class structure patch as a separate review). This addresses bug QPID-3401. https://issues.apache.org/jira/browse/QPID-3401 Diffs ----- http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java 1182391 http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java 1182391 http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java 1182391 http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java 1182391 http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/message/AMQMessageDelegate_0_10.java 1182391 Diff: https://reviews.apache.org/r/2364/diff Testing ------- All existing tests in AddressBasedDestination test pass (with the exception of the Durable subscription test). Thanks, rajith
