[
https://issues.apache.org/jira/browse/QPID-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183334#comment-13183334
]
Robbie Gemmell commented on QPID-3717:
--------------------------------------
The general blocking/unblocking via the queues seems good to me, but I am a
little confused by the _outstandingCredit usage in ServerSession.enqueue(). Its
not clear to me how this will block and then unblock successfully as the
unblock() call used by the queue is the only other thing that alters its value
and wont have any effect if the queue wasnt originally blocked, which it may
not be. Also, it doesnt look like _outstandingCredit plays nicely in situations
where PSFC isnt enabled, as nothing except PSFC code can increment it again
once it has been decremented?
> [Java Broker] Implement Producer Side Flow Control for 0-10
> -----------------------------------------------------------
>
> Key: QPID-3717
> URL: https://issues.apache.org/jira/browse/QPID-3717
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
>
> Implement Producer Side Flow Control for the 0-10 codepath in the Java Broker.
> Note, this JIRA covers functionality analogous to the producer side flow
> control functionality in the 0-8/0-9/0-9-1 codepath in the Java Broker (see
> QPID-942). This does not attempt to replicate the feature of the C++ broker
> (which uses delayed acknowledgement for message transfers (see QPID-2935).
> The implementation here uses the work done in QPID-1646 to replicate the
> functionality previously achieved by using channel.flow. The logic exactly
> duplicates that in place in the 0-8/9/9-1 codepath. Small changes are
> necessary to the client to provide the expected log messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
