[ 
https://issues.apache.org/jira/browse/QPID-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187902#comment-13187902
 ] 

Nuno Santos commented on QPID-3754:
-----------------------------------

Looked through the patches and ran the additional tests, all looks good:

$ rake test
(in /home/nsantos/tmp/qpid-ruby/Qpid/qpid/cpp/bindings/qpid/ruby)
rm -r coverage
.............................................................................................................
Finished in 0.102052 seconds
109 examples, 0 failures

$ patch -p6 < 
~/tmp/0001-Provides-a-unit-tests-for-Qpid-Messaging-Address.to_.patch 
patching file spec/qpid/address_spec.rb
$ patch -p6 < 
~/tmp/0002-Added-Rspec-tests-for-Qpid-Messaging-encode-and-deco.patch 
patching file lib/qpid/encoding.rb
patching file spec/qpid/encoding_spec.rb

$ rake test
(in /home/nsantos/tmp/qpid-ruby/Qpid/qpid/cpp/bindings/qpid/ruby)
rm -r coverage
.................................................................................................................
Finished in 0.066258 seconds
113 examples, 0 failures

                
> Takes the Ruby bindings to 100% unit test coverage.
> ---------------------------------------------------
>
>                 Key: QPID-3754
>                 URL: https://issues.apache.org/jira/browse/QPID-3754
>             Project: Qpid
>          Issue Type: Improvement
>    Affects Versions: 0.15
>            Reporter: Darryl L. Pierce
>         Attachments: 
> 0001-Provides-a-unit-tests-for-Qpid-Messaging-Address.to_.patch, 
> 0002-Added-Rspec-tests-for-Qpid-Messaging-encode-and-deco.patch
>
>
> Adds unit tests to Address and the encoding methods. With this patch set the 
> code is 100% unit tested.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to