----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3570/#review4503 -----------------------------------------------------------
/branches/qpid-3603-2/qpid/cpp/src/qpid/broker/ConnectionObservers.h <https://reviews.apache.org/r/3570/#comment10094> I don't think that the class "ConnectionObservers" IS-A "ConnectionObserver" itself it seems to me that it has-a collection of "ConnectionObserver"s and delegates to them. I think you should completely remove the inheritance relationship. - Andrew On 2012-01-20 17:47:07, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3570/ > ----------------------------------------------------------- > > (Updated 2012-01-20 17:47:07) > > > Review request for qpid, Gordon Sim and Kenneth Giusti. > > > Summary > ------- > > > This commit introduces a ConnectionObserver, needed by the HA code to get > notified of connections opening. > I also took the LinkRegistry::notify* calls out of Connection and refactored > LinkRegistry to use a ConnectionObserver. > > Do the ConnectionObserver changes this look good to put on trunk? > > > Diffs > ----- > > /branches/qpid-3603-2/qpid/cpp/src/Makefile.am 1233690 > /branches/qpid-3603-2/qpid/cpp/src/ha.mk 1233690 > /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/Broker.h 1233690 > /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/Connection.cpp 1233690 > /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/ConnectionObserver.h > PRE-CREATION > /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/ConnectionObservers.h > PRE-CREATION > /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1233690 > /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/ConnectionExcluder.h > PRE-CREATION > /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/HaBroker.h 1233690 > /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/HaBroker.cpp 1233690 > /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/HaPlugin.cpp 1233690 > /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/Settings.h 1233690 > /branches/qpid-3603-2/qpid/cpp/src/tests/ha_tests.py 1233690 > > Diff: https://reviews.apache.org/r/3570/diff > > > Testing > ------- > > > Thanks, > > Alan > >
