[ 
https://issues.apache.org/jira/browse/QPID-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192939#comment-13192939
 ] 

Rob Godfrey commented on QPID-3604:
-----------------------------------

Rajith, your latest commit seems to have broken the 0-9-1 build:

java.lang.NullPointerException
        at 
org.apache.qpid.client.BasicMessageProducer_0_8.declareDestination(BasicMessageProducer_0_8.java:58)
        at 
org.apache.qpid.client.BasicMessageProducer.<init>(BasicMessageProducer.java:139)
        at 
org.apache.qpid.client.BasicMessageProducer_0_8.<init>(BasicMessageProducer_0_8.java:51)
        at 
org.apache.qpid.client.AMQSession_0_8.createMessageProducer(AMQSession_0_8.java:478)
        at 
org.apache.qpid.client.AMQSession_0_8.createMessageProducer(AMQSession_0_8.java:85)
        at org.apache.qpid.client.AMQSession$7.execute(AMQSession.java:2679)
        at org.apache.qpid.client.AMQSession$7.execute(AMQSession.java:2670)
        at 
org.apache.qpid.client.AMQConnectionDelegate_8_0.executeRetrySupport(AMQConnectionDelegate_8_0.java:349)
        at 
org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:577)
        at 
org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
        at 
org.apache.qpid.client.AMQSession.createProducerImpl(AMQSession.java:2668)
        at 
org.apache.qpid.client.AMQSession.createProducer(AMQSession.java:1199)
        at org.apache.qpid.client.AMQSession.createProducer(AMQSession.java:120)
        at 
org.apache.qpid.client.prefetch.PrefetchBehaviourTest.testConnectionStop(PrefetchBehaviourTest.java:212)
        at 
org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:242)
        at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:135)

Please run both the 0-9-1 and 0-10 builds before committing a change
                
> If the connection is stopped the client should release all it's messages in 
> the prefetch buffer
> -----------------------------------------------------------------------------------------------
>
>                 Key: QPID-3604
>                 URL: https://issues.apache.org/jira/browse/QPID-3604
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: 0.15
>
>
> When connection.stop() is called, the JMS client should release all it's 
> messages in the prefetch buffer.
> For all we know, the connection may never be started (depending on 
> application logic) and those messages will be stuck on the prefetch buffer. 
> Releasing it will allow another consumer to get them (in the case of a shared 
> queue case).
> Another less severe but nevertheless an undesirable side affect of this is 
> the client getting more messages than required by the capacity or prefetch 
> arguments. See QPID-3602
> This may not be a big issue if the client is prefetching a few messages, but 
> if prefetching something like 5000 messages, this could potentially cause a 
> lethal spike in the clients memory usage.
> Even in low capacity/prefetch values, if the messages are large (say in the 
> mega byte range) this could potentially put the client under memory pressure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to