[ 
https://issues.apache.org/jira/browse/QPID-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-3775:
-----------------------------

    Attachment: 
0001-QPID-3775-Automate-the-manual-persistent-store-tests-updated.patch

Hi Keith,

I and Andrew reviewed your patch and found some tiny issues which we fixed in a 
new patch attached 
(0001-QPID-3775-Automate-the-manual-persistent-store-tests-updated.patch):

1) changed BDBBackupTest to be able to run it on Windows
2) fixed SpawnedBrokerHolder#kill() to use kill -KILL <pid> to kill the broker 
process, fixed SpawnedBrokerHolder#shutdown() to utilize process.destroy() to 
destroy broker gracefully
3) reverted back some changes in FailoverBaseCase in order not to stop broker 
abruptly as failover tests require some additional changes (IMHO, we need to 
change FailoverBaseCase to utilize BrokerHolder#kill() in a separate review )

                
> Automate the manual persistent store tests
> ------------------------------------------
>
>                 Key: QPID-3775
>                 URL: https://issues.apache.org/jira/browse/QPID-3775
>             Project: Qpid
>          Issue Type: Task
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>         Attachments: 
> 0001-QPID-3775-Automate-the-manual-persistent-store-tests-updated.patch, 
> 0001-QPID-3775-Automate-the-manual-persistent-store-tests.patch
>
>
> The Java broker currently has a suite of manual persistent store tests. These 
> tests should be automated as part of the System Test suite.
> BDB-Qpid-1        Verifies that committed messages survive clean broker 
> shutdown, after fully completing a number of transactions.
> BDB-Qpid-2        Verifies that committed messages survive immediate (kill 
> -9) broker shutdown, after fully completing a number of transactions.
> BDB-Qpid-5        Verifies that committed messages survive clean broker 
> shutdown, when broker is shutdown mid-transaction.
> BDB-Qpid-6        Verifies that committed messages survive immediate (kill 
> -9) broker shutdown, when broker is shutdown mid-transaction.
> BDB-Qpid-7        Verifies that committed messages survive client connection 
> termination, when clients connection is closed mid-transaction.
> BDB-Qpid-8        Verifies that committed messages survive message store 
> backup and restore, when broker is restarted on a restored backup.
> The non-store implementation specific tests should be incorporated into the 
> PersistentStoreTest system test.  The test BDB-Qpid-8 is BDB specific and a 
> should be implemented as in BDB specific system test.
> QBTC will need to be extended to permit the shutting down the Broker down 
> gracefully (using kill -15).  Currently the framework uses 
> java.lang.Process#destroy() which is implemented as kill -9.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Reply via email to