[
https://issues.apache.org/jira/browse/QPID-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207103#comment-13207103
]
jirapos...@reviews.apache.org commented on QPID-3547:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3839/#review5055
-----------------------------------------------------------
Ship it!
This looks good. The only thing I might have done differently is to use "%r"
instead of "%s" for the arguments. However, since the arguments are always of
type "dict", both formats are treated the same so it's fine the way it is.
- Ted
On 2012-02-10 21:02:10, Gordon Sim wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3839/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-10 21:02:10)
bq.
bq.
bq. Review request for Kenneth Giusti, Ted Ross and Nuno Santos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. So that for e.g. headers exchanges you can actually see what the bindings
are.
bq.
bq.
bq. This addresses bug QPID-3547.
bq. https://issues.apache.org/jira/browse/QPID-3547
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/tools/src/py/qpid-config 1079726
bq.
bq. Diff: https://reviews.apache.org/r/3839/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Basic
bq.
bq.
bq. Thanks,
bq.
bq. Gordon
bq.
bq.
> qpid-config currently doesn't display useful information about headers
> exchange bindings
> ----------------------------------------------------------------------------------------
>
> Key: QPID-3547
> URL: https://issues.apache.org/jira/browse/QPID-3547
> Project: Qpid
> Issue Type: New Feature
> Components: Tools
> Affects Versions: 0.10
> Environment: qpid-config python tool
> Reporter: Fraser Adams
> Priority: Trivial
> Labels: features
>
> qpid-config doesn't display useful binding information for headers exchange
> bindings, for the headers exchange the binding key is really just a handle.
> The most basic fix would be to test for the presence of bind.arguments in the
> QueueListRecurse and ExchangeListRecurse methods and if present to display
> the bind.arguments.
> For example in QueueListRecurse:
> if bind.arguments:
> print " bind [%s] => %s %s" %
> (bind.bindingKey, ename, bind.arguments)
> else:
> print " bind [%s] => %s" % (bind.bindingKey,
> ename)
> and in ExchangeListRecurse:
> if bind.arguments:
> print " bind [%s] => %s %s" %
> (bind.bindingKey, qname, bind.arguments)
> else:
> print " bind [%s] => %s" % (bind.bindingKey,
> qname)
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
