[ 
https://issues.apache.org/jira/browse/QPID-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217625#comment-13217625
 ] 

Rob Godfrey commented on QPID-792:
----------------------------------

bq. I realise forcing users to specify queue or topic in the address string 
wouldnt be consistent with the other clients, but I do think its worth noting 
that the Java client isn't entirely consistent with the other clients for 
obvious reasons and trying to make it more so isnt necessarily always going to 
be a helpful or useful thing.

I don't think the queue/topic distinction even needs to go into the address - 
it should only needs to be defined some way in the JNDI source

e.g. in a properties file then things that begin 

{code}
queue.<NAME>=<address string>
{code}

would be queues, and

{code}
topic.<NAME>=<address string>
{code}

would be topics
                
> Need to revise QueueBrowser implementation strategy
> ---------------------------------------------------
>
>                 Key: QPID-792
>                 URL: https://issues.apache.org/jira/browse/QPID-792
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: M3
>            Reporter: Rajith Attapattu
>            Assignee: Robbie Gemmell
>             Fix For: 0.15
>
>
> While debuggin and issue I noticed the following behaviour in the 
> AMQQueueBrowser class.
> 1) When we create a queue browser we do a subscribe immediately
> followed by a cancel. (And then we subscribe again when we enumerate).
> The rationale for doing so it to verify the selector is valid. This is
> very confusing for customers who look at the log and it is not appropriate 
> IMHO.
> Currently we use client side selectors, so it is easy validate this. The
> above step is completely unnecessary.
> If we are to use server side selectors the right way to do is
> a)Send a subscribe with the selector
> b)Give message credits only when you call the enumerate method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to