[ 
https://issues.apache.org/jira/browse/QPID-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219621#comment-13219621
 ] 

Robbie Gemmell commented on QPID-3605:
--------------------------------------

TopicExchange.createSelectorFilter() now does more than creating selector 
filter, it should be renamed for clarity. There are a load of if statements 
without any braces.

I think it would be good if the test published some messages on a different 
connection that the no-local subscriber *could* get but deliberately doesnt 
retrieve before the broker restart, just to ensure they do get delivered after 
the restart and reconnection.

As discussed in person earlier, the additional then removal of no-local (or 
vice versa) will interact with the selector change verification code and 
provoke an unsubscribe (queue-delete) at reconnect, but we think that is 
reaosnable enough.
                
> Durable subscriber with no-local true receives messages on re-connection
> ------------------------------------------------------------------------
>
>                 Key: QPID-3605
>                 URL: https://issues.apache.org/jira/browse/QPID-3605
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>
> If a durable subscriber using no-local true reconnects to the Java Broker, it 
> receives all messages that publisher on same connection previously sent.  
> This defect is present on all code paths (0-8..0-10)
> See tests:
> (Java) 
> org.apache.qpid.test.unit.topic.DurableSubscriptionTest#testNoLocalOnConnection
> (Python) qpid_tests.broker_0_10.message.MessageTests.test_no_local_awkward
> This defect does not manifest itself on the CPP Broker, as the CPP broker 
> drops these messages.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to