[
https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222750#comment-13222750
]
Robbie Gemmell commented on QPID-3885:
--------------------------------------
Its a bit late to fix 0.14 :P
I'm not too interested in most of the changes, but I'm not sure I agree these
are debug:
{noformat}
@@ -3194,7 +3194,10 @@ public abstract class AMQSession<C extends
BasicMessageConsumer, P extends Basic
public void setFlowControl(final boolean active)
{
_flowControl.setFlowControl(active);
- _logger.warn("Broker enforced flow control " + (active ? "no longer in
effect" : "has been enforced"));
+ if (_logger.isDebugEnabled())
+ {
+ _logger.debug("Broker enforced flow control " + (active ? "no
longer in effect" : "has been enforced"));
+ }
}
public void checkFlowControl() throws InterruptedException, JMSException
@@ -3208,7 +3211,10 @@ public abstract class AMQSession<C extends
BasicMessageConsumer, P extends Basic
{
_flowControl.wait(_flowControlWaitPeriod);
- _logger.warn("Message send delayed by " +
(System.currentTimeMillis() + _flowControlWaitFailure - expiryTime)/1000 + "s
due to broker enforced flow control");
+ if (_logger.isDebugEnabled())
+ {
+ _logger.debug("Message send delayed by " +
(System.currentTimeMillis() + _flowControlWaitFailure - expiryTime)/1000 + "s
due to broker enforced flow control");
+ }
}
if(!_flowControl.getFlowControl())
{
{noformat}
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: Future
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.14
>
> Attachments: logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info
> to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and
> potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
