[
https://issues.apache.org/jira/browse/QPID-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239980#comment-13239980
]
[email protected] commented on QPID-3918:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4525/#review6449
-----------------------------------------------------------
trunk/qpid/cpp/src/qpid/Modules.cpp
<https://reviews.apache.org/r/4525/#comment14072>
We had this before and took it out. Causes logging before the logging
subsystem is properly initialized. Don't remember the exact symptoms but the
log text can wind up in inappropriate places.
trunk/qpid/cpp/src/qpid/acl/Acl.cpp
<https://reviews.apache.org/r/4525/#comment14073>
I'm not keen on individual try/catch around every step, it makes the code
hard to follow. I'd put a single try-catch around the lot, or just let the
exception get thrown: the management infrastructure will catch it and put the
exception message in the QMF response.
- Alan
On 2012-03-27 19:10:23, Chug Rolke wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4525/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-27 19:10:23)
bq.
bq.
bq. Review request for qpid, Alan Conway, Gordon Sim, and rajith attapattu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add management methods that let a customer drive arbitrary ACL lookup
queries.
bq.
bq.
bq. This addresses bug QPID-3918.
bq. https://issues.apache.org/jira/browse/QPID-3918
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/qpid/cpp/src/qpid/Modules.cpp 1305877
bq. trunk/qpid/cpp/src/qpid/acl/Acl.h 1305877
bq. trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1305877
bq. trunk/qpid/cpp/src/qpid/acl/AclData.cpp 1305877
bq. trunk/qpid/cpp/src/qpid/acl/management-schema.xml 1305877
bq.
bq. Diff: https://reviews.apache.org/r/4525/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Chug
bq.
bq.
> Add management acl-query test methods to C++ broker ACL plugin
> --------------------------------------------------------------
>
> Key: QPID-3918
> URL: https://issues.apache.org/jira/browse/QPID-3918
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker
> Affects Versions: 0.14
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Attachments: acl-test-00-rules.acl, acl-test-00.log, acl-test-00.py
>
>
> In its current form the ACL module is not testable in a customer deployment.
> The ACL module loads the ACL file and from then on only real-world activity
> triggers allow and deny decisions.
> This feature proposal adds two management methods that are directly tied to
> the ACL decision Lookup functions. Using them a customer may start a dummy
> broker process that uses his actual (1) ACL rule file. Then using a
> management application the customer may fire off a set of lookups against his
> rule file to see if the ACL rules deliver the intended results.
> This feature could also be used to augment the self tests. It is very hard to
> stage enough driver code to trigger some of the ACL queries. Using the
> proposed methods then the self test can launch any ACL query directly.
> (1) As usual the ACL file must be bent enough to allow 'anonymous' to have
> access to the management methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
