[ https://issues.apache.org/jira/browse/QPID-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269646#comment-13269646 ]
jirapos...@reviews.apache.org commented on QPID-3983: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5050/ ----------------------------------------------------------- Review request for Andrew Stitcher, Gordon Sim and Ted Ross. Summary ------- In the Ruby VM there are various name collisions in the native Ruby extensions that are occurring as a result of the names of the C++ classes; i.e., the VM creates an instance of Cqpid::Connection when it should be creating an instance of Qpid::Messaging::Connection. This feature adds the prefix "Cpp" to each of the classes that are bound in Ruby via Swig to avoid such name collisions. This addresses bug QPID-3983. https://issues.apache.org/jira/browse/QPID-3983 Diffs ----- trunk/qpid/cpp/bindings/qpid/ruby/spec/qpid/sender_spec.rb 1335016 trunk/qpid/cpp/bindings/qpid/ruby/spec/qpid/session_spec.rb 1335016 trunk/qpid/cpp/bindings/qpid/ruby/spec/qpid/connection_spec.rb 1335016 trunk/qpid/cpp/bindings/qpid/ruby/spec/qpid/message_spec.rb 1335016 trunk/qpid/cpp/bindings/qpid/ruby/spec/qpid/receiver_spec.rb 1335016 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/message.rb 1335016 trunk/qpid/cpp/bindings/qpid/ruby/ruby.i 1335016 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/address.rb 1335016 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/connection.rb 1335016 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/duration.rb 1335016 Diff: https://reviews.apache.org/r/5050/diff Testing ------- Thanks, Darryl > Provides aliases in the Swig Ruby bindings for the C++ class names. > ------------------------------------------------------------------- > > Key: QPID-3983 > URL: https://issues.apache.org/jira/browse/QPID-3983 > Project: Qpid > Issue Type: Improvement > Reporter: Darryl L. Pierce > > In the Ruby VM there are various name collisions in the native Ruby > extensions that are occurring as a result of the names of the C++ classes; > i.e., the VM creates an instance of Cqpid::Connection when it should be > creating an instance of Qpid::Messaging::Connection. > This feature adds the prefix "Cpp" to each of the classes that are bound in > Ruby via Swig to avoid such name collisions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org