[
https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290108#comment-13290108
]
Philip Harvey commented on QPID-3977:
-------------------------------------
Code reviewed and all looks fine.
* I didn't find running ChartUtil very intuitive. It seems that the command
line needs to be something like:
java -cp ".:${QPID_HOME}/lib/*" -DcsvCurrentDir=/location/of/csv/files
org.apache.qpid.disttest.charting.ChartingUtil
chart-defs=/location/of/chartdefs/
Is there a reason why the csv directory is specified with a system property
rather than a command line argument?
* I do think it would be worth modifying ChartUtils to print usage if it's run
with no/invalid args.
* On a related point, I don't think command line option "outputdir" is used
anywhere.
> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
> Key: QPID-3977
> URL: https://issues.apache.org/jira/browse/QPID-3977
> Project: Qpid
> Issue Type: New Feature
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures
> produced by the new distributed test tool (QPID-3936) to be readily
> understood. This new Java module uses JFreeChart to produce charts from the
> CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0
> compatible, the new module perftests/visualisation-jfc is optional and is not
> part of the standard Java build nor does it form part of the distributables.
> If the user wishes to use this module, they must download the JARs
> themselves. This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform
> the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true
> -Dmodules.opt=perftests/visualisation-jfc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
